Repository navigation
fix: decline unclosed function views without crashing repair callers - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unmatched closing brace in a simplified function view made local_flow.Flow subtract from None. Existing callers only catch ValueError/RecursionError for unsupported syntax, so this escaped conversion scheduling and killed the app permuter thread.
Check the closing boundary explicitly and raise the existing unsupported-syntax ValueError. Public liveness, branch-call facts and conversion scheduling then give no advice for that view. Valid closed functions keep their liveness facts. This includes valid C whose alternative preprocessor opening braces become unmatched when directives are blanked; no C or matching verdict is changed.
Validation: three malformed/conditional-view regressions fail with TypeError before the change; all four new controls and the full 96-test library suite pass afterward. Ruff and diff checks pass. Bump the patch version to 0.2.1 for the consuming app. Synthetic fixtures only; no game data, compiler runs or model calls.