Repository navigation
Fix Windows startup migration snapshot flush - #879
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real portable EXE startup smoke check on Blacksmith failed with EBADF in project_migration.durable: Windows FlushFileBuffers requires a writable handle. Open the owned migration snapshot with r+b before fsync, preserving its contents and the existing directory flush on Unix. Added a real file flush regression test. Local validation: 2 passed, 1 Windows-only test skipped; Ruff passed. The release build will verify full startup, health and Stop on Windows before publication.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.