Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an option to return logs that do not match any Sigma rules.
Motivation
In some environments, logs need to be inspected for threat intelligence indicators (such as malicious IP addresses) before being processed by the Sigma Engine.
For example:
Logs are parsed and checked against threat intelligence IP lists before being passed to the Sigma Engine.
A log may contain a known malicious IP address, even if it does not match any Sigma rule.
Currently, logs that do not match any Sigma rule are discarded, making it impossible for downstream processing to use those logs to generate threat intelligence events.
This means potentially valuable threat intelligence matches can be lost simply because the log does not match a Sigma rule.
Changes
Add an option to control whether unmatched logs are returned.
Preserve the existing behavior by default.
When enabled, return logs that do not match any Sigma rule, allowing downstream components to process them independently.
Use Case
This allows applications to perform additional detection based on threat intelligence indicators while still using Sigma rules for behavior-based detection.
It also allows downstream systems to handle both Sigma-matched and unmatched logs without losing potentially relevant threat intelligence information.