Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion model/error.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
package model

import "fmt"
import (
"errors"
"fmt"
)

// ErrDivisionByZero is returned when an integer is divided by zero.
var ErrDivisionByZero = errors.New("integer division by zero")

// MapKeyNotFound is returned when a key is not found in a map.
type MapKeyNotFound struct {
Expand Down
6 changes: 6 additions & 0 deletions model/value_math.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,9 @@ func (v *Value) Divide(other *Value) (*Value, error) {
if err != nil {
return nil, err
}
if b == 0 {
return nil, ErrDivisionByZero
}
return NewValue(a / b), nil
}
if v.IsFloat() && other.IsFloat() {
Expand Down Expand Up @@ -223,6 +226,9 @@ func (v *Value) Modulo(other *Value) (*Value, error) {
if err != nil {
return nil, err
}
if b == 0 {
return nil, ErrDivisionByZero
}
return NewValue(a % b), nil
}
if v.IsFloat() && other.IsFloat() {
Expand Down
16 changes: 16 additions & 0 deletions model/value_math_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package model_test

import (
"errors"
"testing"

"github.com/tomwright/dasel/v3/model"
Expand Down Expand Up @@ -148,3 +149,18 @@ func TestValue_Modulo(t *testing.T) {
t.Run("float", run(model.NewFloatValue(10), model.NewFloatValue(3), model.NewFloatValue(1)))
})
}

func TestValue_IntegerDivisionByZero(t *testing.T) {
t.Run("divide", func(t *testing.T) {
_, err := model.NewIntValue(1).Divide(model.NewIntValue(0))
if !errors.Is(err, model.ErrDivisionByZero) {
t.Errorf("expected %v, got %v", model.ErrDivisionByZero, err)
}
})
t.Run("modulo", func(t *testing.T) {
_, err := model.NewIntValue(1).Modulo(model.NewIntValue(0))
if !errors.Is(err, model.ErrDivisionByZero) {
t.Errorf("expected %v, got %v", model.ErrDivisionByZero, err)
}
})
}