Repository navigation
fix: honor explicit light mode on dark-mode devices - #3
Merged
Merged
Conversation
Deploying tulipfarm-packages with
|
| Latest commit: |
fbd11c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6ecc1948.tulipfarm-packages.pages.dev |
| Branch Preview URL: | https://fix-explicit-light-theme.tulipfarm-packages.pages.dev |
Contributor
Author
|
Published and verified on https://packages.tulipfarm.ai: light mode now overrides a dark device preference and survives reload. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
applyTheme() toggle .dark + toggle .light with the opposite valueMark both theme choices explicitly so Sprout does not fall back to the device dark preference after the visitor selects light. Device preference still applies until a choice is saved.
Evidence
.darkbut left the page dark: computed canvasoklch(0.1826 0.002 264.5).After: Root uses
.light, the canvas isoklch(0.9824 0.0013 286.38), and light persists across detail-page navigation. Maintainer reviewed the local result.Merge Danger
Door: two-way
Blast Radius: theme