Skip to content

build: align browser container runtime with local e2e - #3351

Merged
nperez0111 merged 1 commit into
mainfrom
fix-main-e2e-build-ci
Nov 16, 2026
Merged

nperez0111 merged 1 commit into
mainfrom
fix-main-e2e-build-ci

Conversation

@nperez0111

@nperez0111 nperez0111 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add --init --ipc=host to both E2E job containers, matching tests/docker-run.sh.
  • Reap browser child processes and avoid Docker's default 64 MiB shared-memory limit.
  • Keep existing test assertions, retries, and failure reporting unchanged.

Context

The failed main run reports a WebKit page crash rather than an assertion failure. Container resource exhaustion is suspected, not proven; this change removes the CI/local runtime mismatch.

Validation

  • Docker WebKit shard 1/2: 375 passed, 9 skipped.
  • Workflow formatting and git diff --check pass.
  • PR CI will be monitored before marking this ready.

Summary by CodeRabbit

  • Chores
    • Updated the automated testing setup for more consistent browser test runs. No direct changes to app features or behavior.

@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
blocknote Ready Ready Preview Nov 16, 2026 8:43am UTC
blocknote-website Ready Ready Preview Nov 16, 2026 8:43am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The E2E and E2E PDF jobs add --init --ipc=host to their Playwright containers. The E2E job also documents process cleanup and shared-memory setup.

Changes: E2E container setup

Layer / File(s) Summary
Configure E2E containers
.github/workflows/build.yml
The E2E and E2E PDF containers add --init --ipc=host. Comments in the E2E job describe process cleanup and shared-memory setup.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: yousefed, matthewlipski

Merge Risk: Minimal · up to c7535

This updates CI container options to match local E2E runs. It does not affect production code, and no merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description check Passed The description follows the repository template in part. It has a Summary section that states the change clearly. It has a Context section that explains the failed run and the suspected cause. It has …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title "build: align browser container runtime with local e2e" matches the change. The workflow now runs the E2E and E2E PDF Playwright containers with --init --ipc=host, matching the local `test…
Full details: Description check

Explanation

The description follows the repository template in part. It has a Summary section that states the change clearly. It has a Context section that explains the failed run and the suspected cause. It has a Validation section with test results. The template sections Rationale, Changes, Impact, Testing, Screenshots/Video, Checklist, and Additional Notes are absent or only partly covered. The Summary bullets partly cover Changes. Validation partly covers Testing. The Checklist items are not ticked or addressed.

Resolution

Consider adding the missing template sections or mapping existing content to them. Add a Rationale section that states why the containers need --init --ipc=host. Add an Impact section that states the effect on existing CI jobs. Add the Checklist with each item marked or explained. Add Screenshots/Video as N/A if not applicable.

Full details: Title check

Explanation

The title "build: align browser container runtime with local e2e" matches the change. The workflow now runs the E2E and E2E PDF Playwright containers with --init --ipc=host, matching the local tests/docker-run.sh setup. The title names the main change (container runtime alignment with local E2E) in a short, specific sentence. It does not describe the reasoning, which is a suspected shared-memory or resource issue, but a title does not need that detail.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the runner's queue,
Two containers start with options new.
--init helps clean up each run,
Shared memory joins the setting done.
The rabbit hops along, content.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2cfd407b-8c7f-4983-884a-08830462a346
Commits

Reviewing files that changed from the base of the PR and between fa9fe69 and c753502.

Files selected for processing: 1

  • .github/workflows/build.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@nperez0111 nperez0111 changed the title fix(ci): align browser container runtime with local e2e build: align browser container runtime with local e2e Nov 16, 2026
@pkg-pr-new

pkg-pr-new Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/@blocknote/ariakit@3351

@blocknote/code-block

npm i https://pkg.pr.new/@blocknote/code-block@3351

@blocknote/core

npm i https://pkg.pr.new/@blocknote/core@3351

@blocknote/diagram-block

npm i https://pkg.pr.new/@blocknote/diagram-block@3351

@blocknote/mantine

npm i https://pkg.pr.new/@blocknote/mantine@3351

@blocknote/math-block

npm i https://pkg.pr.new/@blocknote/math-block@3351

@blocknote/react

npm i https://pkg.pr.new/@blocknote/react@3351

@blocknote/server-util

npm i https://pkg.pr.new/@blocknote/server-util@3351

@blocknote/shadcn

npm i https://pkg.pr.new/@blocknote/shadcn@3351

@blocknote/xl-ai

npm i https://pkg.pr.new/@blocknote/xl-ai@3351

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/@blocknote/xl-docx-exporter@3351

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/@blocknote/xl-email-exporter@3351

@blocknote/xl-multi-column

npm i https://pkg.pr.new/@blocknote/xl-multi-column@3351

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/@blocknote/xl-odt-exporter@3351

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/@blocknote/xl-pdf-exporter@3351

@blocknote/xl-typst-exporter

npm i https://pkg.pr.new/@blocknote/xl-typst-exporter@3351

commit: c753502

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.2
Preview removed because the pull request was closed.
2026-11-16 08:53 UTC

@nperez0111
nperez0111 merged commit 7f714c0 into main Nov 16, 2026
50 checks passed
@nperez0111
nperez0111 deleted the fix-main-e2e-build-ci branch November 16, 2026 08:53

This branch was successfully deployed

2 active deployments
Preview – blocknote-website — c7535027 Deployed Nov 16, 2026 by vercel[bot]
Preview – blocknote — c7535027 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant