Skip to content

chore: upgrade Vite+ to tsrs type-aware linting - #3366

Open
nperez0111 wants to merge 1 commit into
mainfrom
evaluate-oxlint-tsrs-backend
Open

nperez0111 wants to merge 1 commit into
mainfrom
evaluate-oxlint-tsrs-backend

Conversation

@nperez0111

@nperez0111 nperez0111 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade Vite+ to 1.7.0 and use its bundled tsrs backend; remove the standalone tsgolint dependency and update release-age exemptions.
  • Configure VS Code to use the workspace Oxc config and native TypeScript language service.
  • Share the initialized block-spec mapped type and explicitly type the schema initializer to resolve newer compiler inference errors without weakening the public types.
  • Preserve existing lint rules. Builds and editor language features continue using TypeScript 7.0.2; tsrs is used for type-aware linting only.

Validation

  • Full type-aware lint/type check: 0 errors, 10 existing warnings.
  • Focused schema check and pre-commit checks pass.
  • Core tests: 121 files passed, 1,711 tests passed, 20 expected failures, 9 skipped.
  • Frozen-lockfile install and formatting checks pass.
  • Earlier local benchmarks showed approximately 49% lower lint wall time and 38% lower peak RSS; these compare toolchain/compiler versions, not an isolated Rust-versus-Go backend change.

No full build or Docker browser suite was run for this PR.

Summary by CodeRabbit

  • Chores
    • Updated recommended editor extensions and TypeScript settings to support the current development toolchain.
    • Refreshed development tooling versions and adjusted related workspace configuration.
    • Removed an unused development dependency.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
blocknote Ready Ready Preview Nov 18, 2026 6:40am UTC
blocknote-website Ready Ready Preview Nov 18, 2026 6:40am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The changes update VS Code recommendations and settings, revise workspace tooling configuration, and use a named mapped type for initialized block specifications in CustomBlockNoteSchema.

Changes: Editor and workspace tooling

Layer / File(s) Summary
Editor and workspace tooling configuration
.vscode/extensions.json, .vscode/settings.json, package.json, pnpm-workspace.yaml
VS Code recommendations add TypeScriptTeam.native-preview. Settings configure Oxc and experimental Tsgo. The workspace updates the vite-plus version range and release-age exclusions, and removes oxlint-tsgolint from root development dependencies.

Block schema typing

Layer / File(s) Summary
Initialized block specifications
packages/core/src/schema/schema.ts
CustomBlockNoteSchema uses InitializedBlockSpecs<BSchema> for its blockSpecs property, the init() return type, and the constructed object cast. The initialization behavior is unchanged.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

Suggested reviewers: matthewlipski, yousefed

Merge Risk: Minimal · up to c20dc

This change upgrades the lint tooling, adjusts editor settings, and refactors a type declaration in the block schema without changing runtime behavior. No merge-blocking risk was found. Editor-side type-aware diagnostics are the only unverified area.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The description follows the template structure in part. It has a Summary, Validation, and a note about testing. It lacks the Rationale, Impact, Changes, Screenshots/Video, Checklist, and Additional No… Add the missing template sections: Rationale (why upgrade to tsrs and change the schema typing), Changes (a file-level list), Impact (effects on existing lint rules and editor behavior), and the Checklist with each item marked. Add Screensh…
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title names the main change, a Vite+ upgrade to use tsrs for type-aware linting. It follows the conventional-commit style. The changeset also includes VS Code, schema typing, and dependency edits,…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change, a Vite+ upgrade to use tsrs for type-aware linting. It follows the conventional-commit style. The changeset also includes VS Code, schema typing, and dependency edits, but the title does not need to cover every detail.

Full details: Description check

Explanation

The description follows the template structure in part. It has a Summary, Validation, and a note about testing. It lacks the Rationale, Impact, Changes, Screenshots/Video, Checklist, and Additional Notes sections. The Summary covers the main changes, and the Validation section covers testing. The Rationale is partly implied by the benchmark note but is not stated as a reason for the change.

Resolution

Add the missing template sections: Rationale (why upgrade to tsrs and change the schema typing), Changes (a file-level list), Impact (effects on existing lint rules and editor behavior), and the Checklist with each item marked. Add Screenshots/Video or state that they do not apply. Add Additional Notes if relevant. Keep the existing Summary and Validation content.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the editor pane,
New settings settle into place.
A mapped type names each block spec,
While workspace versions shift their base.
I nibble greens and hop away,
The schema keeps its shape today.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 037005ad-0e52-4e79-99cd-3ee1e6696c84
Commits

Reviewing files that changed from the base of the PR and between 0f26215 and c20dc05.

Files ignored due to path filters: 1

  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 5

  • .vscode/extensions.json
  • .vscode/settings.json
  • package.json
  • packages/core/src/schema/schema.ts
  • pnpm-workspace.yaml
Files with no reviewable changes: 1

  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@pkg-pr-new

pkg-pr-new Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/@blocknote/ariakit@3366

@blocknote/code-block

npm i https://pkg.pr.new/@blocknote/code-block@3366

@blocknote/core

npm i https://pkg.pr.new/@blocknote/core@3366

@blocknote/diagram-block

npm i https://pkg.pr.new/@blocknote/diagram-block@3366

@blocknote/mantine

npm i https://pkg.pr.new/@blocknote/mantine@3366

@blocknote/math-block

npm i https://pkg.pr.new/@blocknote/math-block@3366

@blocknote/react

npm i https://pkg.pr.new/@blocknote/react@3366

@blocknote/server-util

npm i https://pkg.pr.new/@blocknote/server-util@3366

@blocknote/shadcn

npm i https://pkg.pr.new/@blocknote/shadcn@3366

@blocknote/xl-ai

npm i https://pkg.pr.new/@blocknote/xl-ai@3366

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/@blocknote/xl-docx-exporter@3366

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/@blocknote/xl-email-exporter@3366

@blocknote/xl-multi-column

npm i https://pkg.pr.new/@blocknote/xl-multi-column@3366

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/@blocknote/xl-odt-exporter@3366

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/@blocknote/xl-pdf-exporter@3366

@blocknote/xl-typst-exporter

npm i https://pkg.pr.new/@blocknote/xl-typst-exporter@3366

commit: c20dc05

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.2

QR code for preview link

🚀 View preview at
https://TypeCellOS.github.io/BlockNote/pr-preview/pr-3366/

Built to branch gh-pages at 2026-11-18 06:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

This branch was successfully deployed

2 active deployments
Preview – blocknote-website — c20dc054 Deployed Nov 18, 2026 by vercel[bot]
Preview – blocknote — c20dc054 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant