Repository navigation
fast-FBlc: cluster term info relation iri from r.iri - #14
Merged
Merged
Conversation
Port of the main-branch fix: edges carry `iri`, not `uri`, so every related-individual relation came back with a null iri.
Robbie1977
approved these changes
Nov 5, 2026
Robbie1977
left a comment
Robbie1977
left a comment
Contributor
There was a problem hiding this comment.
Reviewed, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of the main-branch fix to
fast-FBlc, which vfb-k8s'svfb-json-precomputeand the data release's precompute step clone.The Cluster term-info query builds each related individual's relation as
iri: r.uri. Edges in pdb carryiri(plusshort_form,label,type,edge_sig), noturi, so every relation came back with a null iri. Its link then had no target unless the reader fell back to the label. This changes it tor.iri.VFBquery's term-info fallback reuses this query for the new vfb-scRNAseq Sample, Assay and Clustering pages (VirtualFlyBrain/VFBquery#136). That PR also makes VFBquery fall back to the IRI's tail, so either can merge first.