Repository navigation
Bulk import: correct the comment on tolerance.skipRowOnError - #1862
Open
JasonWildMe wants to merge 1 commit into
Open
JasonWildMe wants to merge 1 commit into
JasonWildMe wants to merge 1 commit into
Conversation
The comment described skipRowOnError as skipping a row that has an error. The setting is read but has never been applied: a tolerant import leaves out each field that failed validation and imports the rest of the row. The comment now says so. No behaviour change. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1862 +/- ##
=======================================
Coverage 56.92% 56.92%
=======================================
Files 317 317
Lines 12867 12867
Branches 4171 4184 +13
=======================================
Hits 7324 7324
Misses 5246 5246
Partials 297 297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
UrbanFercec
approved these changes
Nov 10, 2026
UrbanFercec
left a comment
UrbanFercec
left a comment
Contributor
There was a problem hiding this comment.
Checked it against main: toleranceSkipRowOnError is only ever assigned, never read, and a row with field errors still goes to the importer with those fields left out. The new comment matches what the code does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Comment-only correction in
BulkImport.java. No behaviour change.The comment on
tolerance.skipRowOnErrorsaid that, in a tolerant import, a row with an error is skipped unless this setting is false. The setting is read but has never been applied. What a tolerant import (failImportOnError: false) actually does is leave out each field that failed validation and import the rest of the row.The comment now describes that, and notes why the setting is not being wired in: skipping whole rows would change results for existing API clients that use tolerant mode. The React bulk-import page never sends
tolerance, so it is unaffected either way.Testing
None needed: the change is a comment. The file was not recompiled locally; CI will build it.
Any published API documentation outside this repository that describes
skipRowOnErrorshould get the same correction.🤖 Generated with Claude Code