Repository navigation
Conversation
Member
Author
|
Closing this companion PR because OAuth protocol changes have been removed from WordPress/wporg-mu-plugins#775. That PR now preserves the existing callback protocol and requires no WordCamp deployment. This branch is retained for separate OAuth hardening work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds authenticated browser initiation for Meetup recovery. The admin dashboard shows a “Reconnect Meetup” link that generates OAuth state in the current administrator's session. The callback dispatcher checks the administrator capability and nonce during
admin_init, after WordPress loads the current user.Companion to WordPress/wporg-mu-plugins#775. Deploy both changes together: MU-plugins recovery warnings now point to this local initiation page, and its OAuth client validates the returned nonce. This also keeps session-bound state and encoded redirect parameters out of cron and Slack recovery messages.
How to test the changes in this Pull Request:
/wp-admin/?action=wcorg-meetup-authorizeas a network administrator and confirm the “Reconnect Meetup” link appears. Verify it does not appear for an unauthorized user.Validation
Live Meetup authorization, the full WordCamp test suite, and hosted CI were not verified locally.