Repository navigation
Query Filter: Guard against missing key attribute - #732
Merged
Merged
Conversation
Adds an early return when the block key attribute is not set, preventing an "Undefined array key" PHP warning on render. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
This happens due to people adding it via the site editor without the key, mostly in test templates, it's easier to just not render when used incorrectly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keyattribute is not set, preventing anUndefined array key "key"PHP warning.apply_filterscall, matching the existing early-return pattern used for missing options.Test plan
keyattribute still render correctly.keyattribute render nothing and produce no PHP warnings.🤖 Generated with Claude Code