Repository navigation
Skip to: Print the link target script through the core helper - #778
Merged
Merged
Conversation
The script that points the skip link at its target is handed to the WordPress inline script helper, matching how other inline scripts on the sites are printed. The script itself is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skip link's target script is the last inline script in this plugin that echoes its own
<script>tag. This passes it towp_print_inline_script_tag()instead, the same function core uses for inline scripts added withwp_add_inline_script(), so it is built the same way and goes through thewp_inline_script_attributesfilter. The JavaScript is unchanged and still prints in the footer.Testing steps
🤖 Generated with Claude Code