Repository navigation
Conversation
Signed-off-by: Vijay Sri Lakshmanan <vijaysri@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
xfreid
reviewed
Oct 28, 2026
| print(o.decode('ascii')) | ||
| print(e.decode('ascii')) | ||
| if proc.returncode == 0: | ||
| raise Exception("Invalid xclbin passed file-check") |
Collaborator
There was a problem hiding this comment.
You mean "Invalid xclbin passed to file-check"
xfreid
approved these changes
Oct 28, 2026
Collaborator
Do you mean "respects --verbose"? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
xclbinutil --file-check --input was silent when validation passed, leaving users unsure whether the check ran. Add
an explicit success message that respects --quiet. Existing failure messages and exit codes are unchanged.
What has been tested and how
Updated FileCheck unit test, verifying success output in normal and verbose modes,
no compliance message without --file-check, and error messages with nonzero exit codes for all three compliance failure
cases.