Repository navigation
fix: exclude ActiveAdmin 4 prereleases from the dependency - #81
Merged
Merged
Conversation
RubyGems sorts 4.0.0.beta23 below 4.0, so "< 4.0" let bundler pick an ActiveAdmin 4 beta, which the 3.x theme crashes on at boot. Co-Authored-By: Clanker
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the dependency-bound change excluding ActiveAdmin 4.0 prereleases.
No open issues 🎉
What changed in this PR
Tightens the ActiveAdmin dependency bound to prevent incompatible 4.0 prereleases from being selected for the 3.x theme.
Changes:
- Changes the upper bound from
< 4.0to< 4.0.0.a, retaining the>= 3.0minimum.
| File | Description |
|---|---|
active_admin_theme.gemspec |
Updates the ActiveAdmin upper bound to exclude 4.0 prereleases. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gemspec allowed
activeadmin < 4.0. RubyGems sorts prereleases below their release, so4.0.0.beta23satisfies that bound, and bundler picks it whenever an app allows prereleases. The 3.x theme then crashes at boot withundefined method 'add_current_user_to_menu'.< 4.0.0.ais the lowest possible 4.0 version, so it excludes every 4.0 prerelease and 4.0 itself.Verified: a fresh bundle resolves ActiveAdmin 3.5.2 instead of 4.0.0.beta23, and
rake css testpasses.