Repository navigation
feat: cmp 1.10.3 - #559
Merged
Merged
feat: cmp 1.10.3#559
Conversation
Syer10
reviewed
Mar 21, 2026
DevSrSouza
approved these changes
Mar 24, 2026
Syer10
reviewed
Mar 24, 2026
| navigatorSaver.saver(screens, key, stateHolder, disposeBehavior, parent) | ||
| } | ||
|
|
||
| return rememberSaveable(saver = saver, key = key) { |
Contributor
There was a problem hiding this comment.
Will this change the behaviour?
Collaborator
Author
There was a problem hiding this comment.
The main reason was deprecation. Previous saver hasn't a key in the remember arguments so we were reusing the same saver to different keys. Maybe remove from rememberSaveable and put to remember above.
Collaborator
Author
There was a problem hiding this comment.
Moved key to remember. Instead of creating Navigators changing the key now create a saver. Changing the saver creates a new Navigator too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#556