Skip to content

[Fix]: Release notes not triggered on tag creation - #262

Merged
kovtcharov merged 11 commits into
mainfrom
kalin/fix-release-notes-gen
Jan 28, 2026
Merged

kovtcharov merged 11 commits into
mainfrom
kalin/fix-release-notes-gen

Conversation

@kovtcharov

@kovtcharov kovtcharov commented Jan 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes release notes not being generated when tags are created. The root cause was that GitHub Actions workflows triggered using GITHUB_TOKEN do not trigger subsequent release: [created] events.

Solution: Changed claude.yml to use workflow_run trigger instead of release trigger, so it runs after the PyPi workflow completes.

Changes

  • Changed trigger from release: [created] to workflow_run: workflows: ["PyPi"]
  • Added validation step to verify semantic version format (vX.Y.Z) and release existence
  • Added explicit tag fetching (git fetch --tags) for reliable git operations
  • Added if conditions to skip steps gracefully when validation fails
  • Added fallback handling for failure notifications
  • Closes [bug]: fix Claude release notes generator #199

How It Works

Tag pushed (v1.2.3)
    │
    ├── pypi.yml runs
    │   └── Creates GitHub release with empty notes
    │
    └── claude.yml triggers (workflow_run)
        ├── Validates: PyPi succeeded + tag is vX.Y.Z + release exists
        ├── Generates release notes with Claude
        └── Updates GitHub release

@kovtcharov
kovtcharov requested a review from itomek-amd January 26, 2026 22:09
@kovtcharov kovtcharov self-assigned this Jan 26, 2026
@kovtcharov kovtcharov added devops DevOps/infrastructure changes claude labels Jan 26, 2026
@kovtcharov kovtcharov added this to the v0.15.3 milestone Jan 26, 2026
Comment thread .github/workflows/claude.yml Fixed
kovtcharov and others added 3 commits January 26, 2026 14:15
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@github-actions github-actions Bot added the dependencies Dependency updates label Jan 26, 2026
@kovtcharov-amd
kovtcharov-amd added this pull request to the merge queue Jan 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 27, 2026
@kovtcharov
kovtcharov enabled auto-merge January 28, 2026 19:54
@kovtcharov
kovtcharov added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit 7e1490f Jan 28, 2026
58 checks passed
@kovtcharov
kovtcharov deleted the kalin/fix-release-notes-gen branch January 28, 2026 20:28
itomek pushed a commit that referenced this pull request Mar 12, 2026
# 

## Summary

Fixes release notes not being generated when tags are created. The root
cause was that GitHub Actions workflows triggered using `GITHUB_TOKEN`
do not trigger subsequent `release: [created]` events.

**Solution:** Changed `claude.yml` to use `workflow_run` trigger instead
of `release` trigger, so it runs after the PyPi workflow completes.

## Changes

- Changed trigger from `release: [created]` to `workflow_run: workflows:
["PyPi"]`
- Added validation step to verify semantic version format (`vX.Y.Z`) and
release existence
- Added explicit tag fetching (`git fetch --tags`) for reliable git
operations
- Added `if` conditions to skip steps gracefully when validation fails
- Added fallback handling for failure notifications
- Closes #199 

## How It Works

```
Tag pushed (v1.2.3)
    │
    ├── pypi.yml runs
    │   └── Creates GitHub release with empty notes
    │
    └── claude.yml triggers (workflow_run)
        ├── Validates: PyPi succeeded + tag is vX.Y.Z + release exists
        ├── Generates release notes with Claude
        └── Updates GitHub release
```

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude dependencies Dependency updates devops DevOps/infrastructure changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: fix Claude release notes generator

3 participants