Repository navigation
Conversation
pj991207
marked this pull request as draft
November 3, 2026 10:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft status
Draft for layout feedback. The spacing change is measured, but its desirability and the value of a geometry regression test need agreement on the intended composer design.
Problem
The composer's model picker reserves 240px even when its label is shorter. With a 1280px fixture window the wrapper is 240px wide and its button 134.4px wide, leaving 105.6px after the label.
Change
Use the intrinsic flex basis with a 240px maximum. Keep shrinking enabled so the send/stop row retains the protection added for #208. The same wrapper now measures 134.4px.
Reproduction
At a 1280px fixture viewport, select the short-label model used by the regression. Compare the picker wrapper and button widths: baseline 240px vs 134.4px; patched both approximately 134.4px.
Validation
The short-label regression fails on
5e3d726and passes with the fix. All 622 GUI unit tests and 4 Chromium E2E tests pass, covering the width change, send/stop containment at 900/1100px and the existing composer overflow case. Extra probes at 760/640/520px found existing action overflow on both main and this branch; broader responsive layout needs separate work.Tested PR head:
405734b5a1345d7bddad7245a4958902b780599c. At this documentation update,pytest,gui-unitandgui-e2eall report success for this head: CI run. Local results above are the previously recorded checks; this body update does not claim a new local test run.Evidence and limitations
These captures show the actual Chromium GUI with the same fixture. The change is the reserved space beside a short label; it does not fix the pre-existing narrow-width overflow. The measured gap alone does not establish that the layout should change.
Related work
Retains the shrink behavior protecting the composer actions from #208. No upstream user request or blocked interaction has been established for the short-label spacing.