Repository navigation
test: fix the settings smoke test after the network edit button was renamed - #234
Merged
Arpit-Khandelwal merged 1 commit intoNov 5, 2026
Merged
Conversation
Contributor
Author
|
Heads-up: the failing E2E (smoke) check on #229, #230 and #231 is the same test every time, |
Arpit-Khandelwal
approved these changes
Nov 5, 2026
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke test
e2e/ui.spec.ts:288("every choice survives a reload and a restart") fails on main and on every open PR. It times out waiting for a button named "Edit network".#32 renamed that button to
Edit ${network name}(better for screen readers). The test still looked for the old name. Now it opens the first network with/^Edit /, and after the rename it finds the button by its new name, "Edit Office fibre". That also checks the rename reached the button's label.Test-only change.
npx playwright test e2e/ui.spec.ts --repeat-each=3: 33 passed.