Skip to content

test: fix the settings smoke test after the network edit button was renamed - #234

Merged
Arpit-Khandelwal merged 1 commit into
anmolkapil:mainfrom
dxmoc:fix/settings-survive-restart
Nov 5, 2026
Merged

Arpit-Khandelwal merged 1 commit into
anmolkapil:mainfrom
dxmoc:fix/settings-survive-restart

Conversation

@dxmoc

@dxmoc dxmoc commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

The smoke test e2e/ui.spec.ts:288 ("every choice survives a reload and a restart") fails on main and on every open PR. It times out waiting for a button named "Edit network".

#32 renamed that button to Edit ${network name} (better for screen readers). The test still looked for the old name. Now it opens the first network with /^Edit /, and after the rename it finds the button by its new name, "Edit Office fibre". That also checks the rename reached the button's label.

Test-only change. npx playwright test e2e/ui.spec.ts --repeat-each=3: 33 passed.

@dxmoc

dxmoc commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Heads-up: the failing E2E (smoke) check on #229, #230 and #231 is the same test every time, ui.spec.ts:288 (settings survive a reload and a restart). It broke when the network edit button was renamed and has nothing to do with those PRs. This PR fixes it, so if you merge #234 first, a re-run of the checks should turn the other three green.

@Arpit-Khandelwal Arpit-Khandelwal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dxmoc. Same fix as my #223, and the smoke check is green here, so I'll merge this one and close mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants