Repository navigation
Fix symbolic prank, CREATE size, empty-balance and source-location bugs - #1253
Merged
Merged
Conversation
…nt tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…l forge builds Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The size was checked against the maximum with the structural Ord on Expr, so every symbolic size, e.g. end - start of the init code after a symbolic-length memory allocation, failed as too large and the path was silently dropped. Simplify it and compare the literal; a size that stays symbolic ends the path as partial. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
accountEmpty compared the balance with Lit 0 structurally, so a balance
that is a term equal to 0, e.g. after a CALL sending x & 0, made the
account non-empty: EXTCODEHASH returned keccak("") instead of 0, and
the account survived the end-of-transaction cleanup of empty touched
accounts. Found by symbolic-lockstep.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
msooseth
force-pushed
the
stack/1-fixes
branch
from
November 13, 2026 14:24
fcc49d2 to
70cc659
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fixes from running
hevm teston spark-psm.prank/startPrankwith a symbolic address explores each possible address instead of failing.CREATE/CREATE2compare a symbolic init code size as a number instead of dropping the path. An account whose balance is a term equal to 0 counts as empty. Source locations are right after an incrementalforge build, and the progress log shows them.Invariant tests also print partially explored paths grouped by source location instead of their expressions.
Part 1 of 7 of splitting #1248.
Checklist