Repository navigation
refactor(voice,ui,config): improve voice UI, focus, and config handling - #792
Merged
Merged
Conversation
- Add VoiceModelRequiredDialog and hook it into chat and input components - Replace focusRequester with focusRequesterAutoFocus across dialogs and main UI - Update VoiceSettingsSection to remove NONE provider from lists - Introduce TtsChunkMode and chunking logic in TextToSpeechService - Refactor VoiceServiceRegistry shutdown hook and caching logic - Update AppConfig migration to drop NONE provider entries - Adjust TtsTextChunker to handle surrogate pairs and per-sentence packing - Update i18n strings for new voice model dialog - Add comprehensive tests for new chunking behavior - Clean up imports and remove deprecated focusRequester calls BREAKING CHANGE: VoiceProvider.NONE is no longer available; users must enable both STT and TTS or disable voice entirely via VoiceConfig.enabled. Update configuration files accordingly.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING CHANGE: VoiceProvider.NONE is no longer available; users must enable both STT and TTS or disable voice entirely via VoiceConfig.enabled. Update configuration files accordingly.
Related Issue(s)
Type of Change
What Changed & Why
How to Test
./gradlew testScreenshots / Recordings (if applicable)
Checklist
main./gradlew spotlessApplyand./gradlew detektlocally./gradlew testand all tests passgit commit -sAdditional Notes