Repository navigation
Fix paragraph font inheritance in rich text spans - #341
Merged
AnEnglishmanInNorway merged 1 commit intoNov 9, 2026
Merged
AnEnglishmanInNorway merged 1 commit into
AnEnglishmanInNorway merged 1 commit into
Conversation
Collaborator
|
Hi Hendrik. I just cherry picked your commit to a branch on my fork and successfully ran a full test suite, so this looks good to go. I have one question, though - what do you do in the album editor to create this situation? I'm thinking I could add a bit of text to the testTextBox.mcf so that we get an example of this sort of text layout into the pixel comparison regression tests. |
AnEnglishmanInNorway
added a commit
that referenced
this pull request
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qt rich text can store a subtitle's font family, point size, weight and italic style on its paragraph, while the child span contains only a colour. The converter previously rendered that span using the body's heading font (for example, a 16 pt italic subtitle became a 26 pt bold heading).
Resolve inline body, paragraph and span styles in inheritance order before selecting the font. Child overrides take precedence. Add a regression test covering paragraph inheritance, colour overrides and a following heading, plus a short architecture note.
Validation:
No private album files or screenshots are included.