Repository navigation
fix: avoid retaining argument placeholder regex state - #258
Open
JunaidAhamed-7777 wants to merge 1 commit into
Open
JunaidAhamed-7777 wants to merge 1 commit into
JunaidAhamed-7777 wants to merge 1 commit into
Conversation
JunaidAhamed-7777
marked this pull request as ready for review
October 13, 2026 17:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{%}should produce one command per argument, so an empty argument list should run no commands.The shared global regular expressions retain
lastIndexwhen empty expansion skips replacement, which can retain a later command or break placeholder expansion in a subsequent API call.Use stateless
String.search()checks for placeholder detection while retaining global replacement.Add eight regressions covering empty expansion through the API and all three CLI entry points, repeated API calls, and later positional, unpacked, and mixed placeholders.
All eight new tests fail against the original implementation; the patched focused suite passes all 47 tests.
Validation on Windows with Node 26.8.1:
npm run checkpasses dependency compatibility, ESLint, unused-code, and TypeScript checks.npm testexercises 276 tests: 272 pass, and four existingissue14cases fail becausermis missing from the default Windows PATH.Human review follows draft submission.