Skip to content

Support MuSig2 address display #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Sjors wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Support MuSig2 address display #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6b6c891
descriptor: parse tr() internal key with _get_expr
Sjors Aug 24, 2026
db6beda
test: display Segwit Miniscript addresses
Sjors Aug 24, 2026
1af462c
test: display MuSig2 addresses
Sjors Aug 24, 2026
0783fb3
descriptor: allow musig() keys in tapscript Miniscript
Sjors Aug 24, 2026
c05eb6c
test: display MuSig2 Miniscript addresses
Sjors Aug 24, 2026
bd03067
descriptor: split BIP 388 placeholder checks from serialization
Sjors Aug 24, 2026
7681850
descriptor: separate derivation key traversal
Sjors Oct 24, 2026
5856786
descriptor: deduplicate BIP 388 key information
Sjors Oct 24, 2026
ca59097
descriptor: parse Segwit Miniscript policies
Sjors Aug 24, 2026
ffd73ba
descriptor: extract single key expression parsing
Sjors Oct 24, 2026
c85b0f5
descriptor: parse tapscript Miniscript policies
Sjors Oct 24, 2026
677038b
displayaddress: require registration for taproot script trees
Sjors Aug 24, 2026
df94c6f
descriptor: support musig() aggregate keys
Sjors Oct 24, 2026
5e15030
displayaddress: require registration for musig()
Sjors Aug 24, 2026
73966d9
test: display taproot Miniscript addresses
Sjors Aug 24, 2026
a7336ff
descriptor: extract ranged derivation path parsing
Sjors Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hwilib/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
RegisteredDescriptor,
parse_descriptor,
MultisigDescriptor,
MusigPubkeyProvider,
TRDescriptor,
PKHDescriptor,
PubkeyProvider,
Expand Down Expand Up @@ -511,7 +512,11 @@ def displayaddress(
return {"address": client.display_multisig_address(addr_type, descriptor)}
is_wpkh = isinstance(descriptor, WPKHDescriptor)
if isinstance(descriptor, PKHDescriptor) or is_wpkh or isinstance(descriptor, TRDescriptor):
if descriptor.subdescriptors:
raise BadArgumentError("tr() descriptors with a script tree require a registered BIP 388 policy; use --registration")
pubkey = descriptor.pubkeys[0]
if isinstance(pubkey, MusigPubkeyProvider):
raise BadArgumentError("musig() addresses require a registered BIP 388 policy; use --registration")
if pubkey.origin is None:
raise BadArgumentError(f"Descriptor missing origin info: {desc}")
if pubkey.origin.fingerprint != client.get_master_fingerprint():
Expand Down
Loading
Loading