Skip to content

feat: support local development and runtime-backed PR review - #25

Merged
chrislacy merged 6 commits into
mainfrom
bart-the-engineer
Oct 13, 2026
Merged

chrislacy merged 6 commits into
mainfrom
bart-the-engineer

Conversation

@chrislacy

Copy link
Copy Markdown
Collaborator

User impact: Engineers can ask their existing Agent to build and inspect local Brave Android changes or review an actual PR build, with clearer expectations for useful runtime evidence and reproducible findings.

The problem

BART's initial skills focused on QA verification, while local development and runtime-backed review needed clearer completion rules. One local development report contained screenshot links but no theme-transition video, so it did not demonstrate the trigger and result continuously. Technical review also needs an actual PR checkout/build and focused fixtures, rather than substituting Nightly or silently fixing the code under review.

Reproduce

  1. Make BART's skills discoverable to an Agent session in a build-capable Brave Core checkout. For an existing Brave Scaffold installation, select its root and enable it in local BART configuration.
  2. Ask /brave-core-bart Implement <issue URL> in this Android checkout on its current branch. Build and commit locally, do not push. Create a QA evidence pack.
  3. For review work, ask /brave-core-bart Perform a technical review of <PR URL>. Check out and sync the PR in this review checkout, build and run it, and construct local fixtures where useful. Keep findings local and do not modify product code.

Observed before this guidance: a reviewed local theme-fix report linked still images without a demo video or standard QA summary. Build/runtime completion and fixture-backed review expectations were not explicit enough. The report is private and is not uploaded by this PR.

Expected: the Agent uses the selected local or pinned PR build, exercises the relevant behavior, and delivers readable evidence with actual results and unassessed scope clearly separated.

The fix

Add an opt-in Brave Scaffold integration that loads its maintained build skill and passes the selected Core checkout explicitly. Define development QA evidence packs, including local HTML, captures, useful build/test/install receipts and sanitized text context, while keeping product commits in Core. Require runtime QA and demo footage for theme/orientation-dependent checks, with explicit incomplete coverage when capture or inspection is blocked; provide an illustrative HTML structure. Keep the existing three-skill architecture and add supporting technical-review guidance for pinned workspace preparation, focused fixtures and findings-first reporting, without implicitly modifying product code or publishing feedback.

Test plan

  • git diff --check origin/main...HEAD - passed.
  • Local Markdown link/anchor and skill-header checks - passed during implementation, including 171 links/anchors after the review additions.
  • TOML example/local configuration checks - verified the disabled example default and enabled local Brave Scaffold selection.
  • Read-only Brave Scaffold context and Android doctor checks - resolved the selected checkout and passed readiness at the time checked; no feature build is claimed by those checks.
  • Parsed the illustrative HTML report and checked its local references - passed; browser-rendered layout was not visually checked.
  • All five included commits verify as signed.
  • End-to-end runtime-backed technical-review demonstration - not yet performed.
  • Consistent changed-build evidence-pack completion under this guidance - needs further live validation.
  • CI passes cleanly

Select an existing Scaffold installation through local TOML configuration and load its maintained build-context skill. Pass BART's Core checkout explicitly, preserve build/test preparation guards and keep runtime assessment with Androperator.
Keep the three-skill entry point, reporting and reproduction architecture. Add PR workspace/build preparation, focused review fixtures and findings-first reporting guidance; preserve changed-build identity through development and QA without dedicated task sub-skills.
@chrislacy
chrislacy merged commit f922e1a into main Oct 13, 2026
1 check passed
@chrislacy
chrislacy deleted the bart-the-engineer branch October 13, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant