Repository navigation
feat: support local development and runtime-backed PR review - #25
Merged
Merged
Conversation
Select an existing Scaffold installation through local TOML configuration and load its maintained build-context skill. Pass BART's Core checkout explicitly, preserve build/test preparation guards and keep runtime assessment with Androperator.
Keep the three-skill entry point, reporting and reproduction architecture. Add PR workspace/build preparation, focused review fixtures and findings-first reporting guidance; preserve changed-build identity through development and QA without dedicated task sub-skills.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User impact: Engineers can ask their existing Agent to build and inspect local Brave Android changes or review an actual PR build, with clearer expectations for useful runtime evidence and reproducible findings.
The problem
BART's initial skills focused on QA verification, while local development and runtime-backed review needed clearer completion rules. One local development report contained screenshot links but no theme-transition video, so it did not demonstrate the trigger and result continuously. Technical review also needs an actual PR checkout/build and focused fixtures, rather than substituting Nightly or silently fixing the code under review.
Reproduce
/brave-core-bart Implement <issue URL> in this Android checkout on its current branch. Build and commit locally, do not push. Create a QA evidence pack./brave-core-bart Perform a technical review of <PR URL>. Check out and sync the PR in this review checkout, build and run it, and construct local fixtures where useful. Keep findings local and do not modify product code.Observed before this guidance: a reviewed local theme-fix report linked still images without a demo video or standard QA summary. Build/runtime completion and fixture-backed review expectations were not explicit enough. The report is private and is not uploaded by this PR.
Expected: the Agent uses the selected local or pinned PR build, exercises the relevant behavior, and delivers readable evidence with actual results and unassessed scope clearly separated.
The fix
Add an opt-in Brave Scaffold integration that loads its maintained build skill and passes the selected Core checkout explicitly. Define development QA evidence packs, including local HTML, captures, useful build/test/install receipts and sanitized text context, while keeping product commits in Core. Require runtime QA and demo footage for theme/orientation-dependent checks, with explicit incomplete coverage when capture or inspection is blocked; provide an illustrative HTML structure. Keep the existing three-skill architecture and add supporting technical-review guidance for pinned workspace preparation, focused fixtures and findings-first reporting, without implicitly modifying product code or publishing feedback.
Test plan
git diff --check origin/main...HEAD- passed.