Repository navigation
Add LocalDate::getMonthDay() - #134
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=========================================
Coverage 99.30% 99.30%
- Complexity 1113 1114 +1
=========================================
Files 48 48
Lines 2458 2460 +2
=========================================
+ Hits 2441 2443 +2
Misses 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Released as 0.10.1. |
Member
|
Thank you, @joelbutcher! |
joelbutcher
added a commit
to joelbutcher/date-time
that referenced
this pull request
Oct 4, 2026
…() to setInstant() atTimeZone() matches Instant::atTimeZone() and LocalDateTime::atTimeZone(), which also return a different type. Also update a ZonedClockTest expectation for the full seconds now emitted by ZonedDateTime::toISOString() (brick#131), and point the MonthDay::now() migration to LocalDate::getMonthDay() (brick#134). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
LocalDate::getMonthDay(), alongside the existinggetYearMonth(),getYearWeek()andgetQuarter()getters.Split out from #133 as discussed: with the
now()methods removed,MonthDaybecomes reachable from aZonedClockvia$clock->getLocalDate()->getMonthDay().🤖 Generated with Claude Code