Repository navigation
GH5169: Make environment-defaulted DotNet switches tri-state - #5170
Merged
Merged
Conversation
- Add ProcessArgumentBuilder AppendSwitch(string, bool?) and AppendSwitch(string, string, bool?) extensions, emitting an explicit true or false value and nothing when null. - Change DotNetRestoreSettings.Interactive, DotNetReferenceAddSettings.Interactive, DotNetProjectConvertSettings.Interactive, DotNetWorkloadInstallSettings.Interactive, DotNetWorkloadRestoreSettings.Interactive and DotNetToolInstallSettings.CreateManifestIfNeeded to bool?, so the environment-derived .NET CLI default can be explicitly opted out of. - Add unit tests for true, false and null values. - fixes cake-build#5169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessArgumentBuilderAppendSwitch(string, bool?)andAppendSwitch(string, string, bool?)extensions.nullemits nothing so the .NET CLI default applies, andtrue/falseemit--switch true/--switch false.booltobool?so the environment-derived default (for example--interactiveis[default: True]in an interactive terminal) can be explicitly opted out of:DotNetRestoreSettings.InteractiveDotNetReferenceAddSettings.InteractiveDotNetProjectConvertSettings.InteractiveDotNetWorkloadInstallSettings.InteractiveDotNetWorkloadRestoreSettings.InteractiveDotNetToolInstallSettings.CreateManifestIfNeeded--interactiveontool install/update/restore,package add/list,workload update/repair,nuget delete, plus--nologo) are left asbool.true,falseandnullvalues.Breaking change: the property type changes from
booltobool?. Assignments still compile, but code that reads the value needs updating.