Repository navigation
GH5173: Add base image support to DotNetPublish container settings extensions - #5174
Merged
Merged
Conversation
… settings extensions - Add optional baseImage parameter to WithContainerArchive, WithContainerLocalRegistry and WithContainerRegistry, replacing any existing base image when set. - Add WithContainerBaseImage extension to set the base image while keeping other container settings. - Add unit tests and an Archive.BaseImage container integration test verifying the image base name label. - fixes cake-build#5173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
baseImageparameter toWithContainerArchive,WithContainerLocalRegistryandWithContainerRegistry. When set, it replaces any existingBaseImage; whennullor whitespace, the existing value is kept.Add a
WithContainerBaseImageextension that sets the base image and keeps all other container settings, i.e.Add unit tests for the new parameter and extension.
Add an opt-in
DotNetPublishContainer.Archive.BaseImageintegration test that publishes to an archive and verifies the image'sorg.opencontainers.image.base.namelabel.fixes Add base image support to DotNetPublish container settings extensions #5173