Repository navigation
Deploy: CodeQL security fixes and dependency upgrades - #2
Merged
Merged
Conversation
- Templates get a narrow TemplateRequestContext instead of Spring's RequestContext; through webApplicationContext any template could read encryption.key and call any bean. JsonNodeObjectWrapper pins DefaultMemberAccessPolicy so getClass() reflection is blocked as well. - CSRF stays enabled on all filter chains and exempts only the API prefix, which authenticates by bearer token or X-API-KEY header. - Request-controlled values pass through LogSanitizer before logging. - EncryptionService concatenates IV and ciphertext without length arithmetic.
- Spring Boot 4.1.2, Gradle 9.8.2; hibernate-community-dialects, sqlite-jdbc and Testcontainers versions come from the Boot BOM again - Angular 22.2, Vitest 5, Playwright 1.64, npm 12 and all other frontend dependencies on their latest releases; vite overridden to 8.3.5 to close the advisories in the 8.3.0 that @angular/build pins - Runtime image applies pending Ubuntu security updates and drops the unused pebble Go binary carrying critical stdlib CVEs - Keycloak 26.8.1 in the OIDC Compose stacks - Ignore .worktrees/
Brings the CodeQL fixes (template sandbox, CSRF, log injection, overflow), Spring Boot 4.1.2, Gradle 9.8.2, the frontend upgrades and the hardened runtime image to master for deployment. Drops the Tomcat and FreeMarker overrides from d67e828: Spring Boot 4.1.2 manages Tomcat 11.0.27 and FreeMarker 2.3.35 itself, which is the removal condition those overrides named.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the fixes from encircle360-oss#4 to
masterso the monorepo image gets rebuilt and deployed.Security
encryption.keyand call any Spring bean throughspringMacroRequestContext.webApplicationContext. They now get the narrowTemplateRequestContextfacade;DefaultMemberAccessPolicyblocksgetClass()reflection.X-API-KEY).LogSanitizerfor request-controlled values in log lines.EncryptionServicewithout length arithmetic.pebbleGo binary (2 critical, 9 high stdlib CVEs).Dependencies
viteoverridden to 8.3.5.Verification
npm audit: 0Breaking
Templates using the Spring form-binding macros (
spring.bind,spring.formInput, …) no longer render.