Repository navigation
Isolate output_style tests from environment - #747
Merged
Merged
Conversation
These tests appear to assume that the COLCON_DEFAULT_OUTPUT_STYLE environment variable is not set when they're invoked. Since testing colcon itself using colcon is a supported scenario, we'll need to isolate the tests from that variable.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #747 +/- ##
=======================================
Coverage 87.25% 87.25%
=======================================
Files 75 75
Lines 4692 4692
Branches 817 817
=======================================
Hits 4094 4094
Misses 468 468
Partials 130 130 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
christophebedard
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests appear to assume that the COLCON_DEFAULT_OUTPUT_STYLE environment variable is not set when they're invoked. Since testing colcon itself using colcon is a supported scenario, we'll need to isolate the tests from that variable.