Repository navigation
[types] Move from dtslint to ESLint - #766
Merged
Merged
Conversation
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MysteryBlokHed
marked this pull request as ready for review
September 3, 2026 00:58
LeaVerou
reviewed
Sep 3, 2026
Member
|
Thanks for working on this! LGTM except the comment I left. Linters forcing you change perfectly valid code is one of my pet peeves. |
dtslint after v0.0.182 is tailored to Definitely Typed and doesn't work well on arbitrary projects. This replaces it with an ESLint plugin to accomplish the same thing. Co-Authored-By: Claude <noreply@anthropic.com>
MysteryBlokHed
force-pushed
the
types/dtslint-to-eslint
branch
from
September 3, 2026 12:47
e6da0db to
222c026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dtslint after v0.0.182 is tailored to Definitely Typed and doesn't work well on arbitrary projects. This replaces it with an ESLint plugin to accomplish the same thing.
Claude was used to do the migration, but I looked the results over myself.