Repository navigation
[parse] Reject unexpected punctuation in color function arguments - #767
Open
ScribleSean wants to merge 1 commit into
Open
ScribleSean wants to merge 1 commit into
ScribleSean wants to merge 1 commit into
Conversation
Co-Authored-By: OpenAI Codex <noreply@openai.com>
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #614.
color(--lchuv 86.8% 42.9)230)currently parses successfully because argument extraction silently discards unmatched punctuation. Reject the function when unmatched content contains anything other than commas or whitespace.Adds 19 invalid-input regressions and four valid-input controls, including alpha, scientific notation,
none, andcalc(NaN). Also removes an extra closing parenthesis in an existing gamut test's expected value, exposed by the stricter parser. This change is limited to unconsumed punctuation; it does not attempt full CSS grammar validation.Validation on base
19eb89f8995d2139436b6d38c7042944bb23a718:Prepared with OpenAI Codex assistance using GPT-6 Astra (
gpt-6-astra), medium reasoning. I review all contributions before submission and remain responsible for the code and this message. The commit includes Codex co-author attribution.