Repository navigation
Enhance Linear REC.2100 support: update HDR handling and add tests - #770
Open
Aditya30ag wants to merge 1 commit into
Open
Aditya30ag wants to merge 1 commit into
Aditya30ag wants to merge 1 commit into
Conversation
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
Fixes #630. Related: color-js/apps#11 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rec2100-linearinherited the default SDR[0, 1]range fromRGBColorSpace. HDR values above 1 were reported as out of gamut, and gamut mapping turned them into white.Change
Following the approach suggested in the issue,
rec2100-linearnow definesrefRange: [0, 1]instead ofrange:src/toGamut.js, the ray-trace lower bound for PQ and HLG read.range[0]from the linear space. It now falls back torefRange, so they keep working.Testing
test/in_gamut.jsandtest/gamut.js. Without the source change they fail.rec2100-pq,rec2100-hlg,rec2020, andp3using the css, raytrace and clip methods. Onlyrec2100-linearchanged.