Repository navigation
op setup: openpilot's own venv in a uv workspace, find op.sh's checkout from outside - #39237
Merged
Merged
Conversation
…rom outside In a uv workspace like xx, where openpilot is a member, uv sync uses the workspace's venv: setup then failed at source .venv/bin/activate, after its exact sync had already uninstalled every package openpilot doesn't need from the workspace's venv. Sync without removing packages there, activate the venv uv used, and have op check and activate that venv too. The fallback for running op.sh from outside a checkout still looked two levels up from tools/, a leftover from when op.sh was in openpilot/tools.
Contributor
Model Replay: Big model (Chestnut)ref for commit 9d257a2: https://raw.githubusercontent.com/commaai/ci-artifacts/refs/heads/model_replay_op-uv-workspace_chestnut/98395b7c5b27882e|0000002b--2686b5a2d0_model_chestnut_9d257a210982f04aacdbdeed12b4aec52273263a.zstModel Replay Differences
All Model Replay Plots
|
Contributor
Model Replay: Small modelref for commit 9d257a2: https://raw.githubusercontent.com/commaai/ci-artifacts/refs/heads/model_replay_op-uv-workspace_tici/98395b7c5b27882e|0000002b--2686b5a2d0_model_tici_9d257a210982f04aacdbdeed12b4aec52273263a.zstModel Replay Differences
All Model Replay Plots
|
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
UV_PROJECT_ENVIRONMENT keeps setup on openpilot's .venv also as a member of a uv workspace, so op's .venv assumptions hold and the workspace's venv is never touched. For a standalone checkout that's uv's default.
haraschax
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.