Repository navigation
Backport windows readdir nul issue - #3268
Merged
harendra-kumar merged 6 commits intoOct 27, 2026
Merged
Conversation
openDirStream passed the UTF-16 path to FindFirstFileW through asCStringUnsafe, which appends a one byte NUL. The second byte of the terminator was uninitialized memory, so the pattern could become dir\*<garbage> and FindFirstFileW failed with ERROR_FILE_NOT_FOUND on an existing directory. asCWString appends a two byte NUL.
The DirIO test-suite is not built on Windows, so the missing wide NUL in the FindFirstFileW pattern of openDirStream was not caught. The new test reads directories with names of 1 to 64 characters, 20 times each.
Bump version in streamly-core/configure.ac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.