Skip to content

fix: FP with 'hh' argument inside URL in referredby/_wp_original_http_referer - #116

Merged
azurit merged 4 commits into
coreruleset:masterfrom
azurit:FP
Nov 10, 2026
Merged

azurit merged 4 commits into
coreruleset:masterfrom
azurit:FP

Conversation

@azurit

@azurit azurit commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

+ adding (?:..) around a regex as current version matches also a lot of other strings other than actual ARGS names.

@azurit

azurit commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

Ready for review.

@EsadCetiner EsadCetiner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an additional test instead of modifying an existing test? I'd prefer not modifying an existing test unless it's incorrect or redundant.

@azurit

azurit commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

Done.

@azurit
azurit merged commit 109f353 into coreruleset:master Nov 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants