[8.x] Fix images, variants and metafields syncing in reverse order

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Release Notes for Shopify
 
+## Unreleased
+
+- Added `craft\shopify\records\ShopifyData::$position`.
+- Fixed a bug where product images, variants, and metafields were synced in reverse order. ([#161](https://github.com/craftcms/shopify/issues/161))
+
 ## 8.2.0 - 2026-10-08
 
 - Improved the memory usage of bulk operation processing.
@@ -95,6 +100,11 @@ See [Upgrading](https://github.com/craftcms/shopify/blob/8.x/README.md#upgrading
 - Fixed a bug where validation errors for the “Context Pricing Countries” setting weren’t displaying correctly.
 - Fixed a bug where `inventory_levels/update` webhooks weren’t triggering a product sync.
 
+## 7.3.1 - 2026-10-19
+
+- Added `craft\shopify\records\ShopifyData::$position`.
+- Fixed a bug where product images, variants, and metafields were synced in reverse order. ([#161](https://github.com/craftcms/shopify/issues/161))
+
 ## 7.3.0 - 2026-10-08
 
 - Improved the memory usage of bulk operation processing.

src/Plugin.php

@@ -79,7 +79,7 @@ class Plugin extends BasePlugin
     /**
      * @var string
      */
-    public string $schemaVersion = '8.1.0';
+    public string $schemaVersion = '8.2.1.0';
 
     /**
      * @inheritdoc

src/jobs/ProcessBulkOperationData.php

@@ -134,6 +134,7 @@ protected function processItem(mixed $item): void
         $record->type = $type;
         $record->data = $item;
         $record->parentId = $item['__parentId'] ?? null;
+        $record->position = $this->objectCount > 0 ? $this->objectCount - 1 - $this->itemOffset : null;
         $record->save();
 
         // Process the data based on the type

src/migrations/Install.php

@@ -61,6 +61,7 @@ public function createTables(): void
             'type' => $this->string(),
             'data' => $this->json(),
             'parentId' => $this->string(),
+            'position' => $this->integer(),
             'dateCreated' => $this->dateTime()->notNull(),
             'dateUpdated' => $this->dateTime()->notNull(),
             'uid' => $this->uid(),

src/migrations/m261016_090000_add_position_to_data_table.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace craft\shopify\migrations;
+
+use craft\db\Migration;
+use craft\shopify\db\Table;
+
+/**
+ * m261016_090000_add_position_to_data_table migration.
+ */
+class m261016_090000_add_position_to_data_table extends Migration
+{
+    /**
+     * @inheritdoc
+     */
+    public function safeUp(): bool
+    {
+        if (!$this->db->columnExists(Table::DATA, 'position')) {
+            $this->addColumn(Table::DATA, 'position', $this->integer()->after('parentId'));
+        }
+
+        return true;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function safeDown(): bool
+    {
+        echo "m261016_090000_add_position_to_data_table cannot be reverted.\n";
+        return false;
+    }
+}

src/records/ShopifyData.php

@@ -22,6 +22,7 @@
  * @property string $type
  * @property string|array $data
  * @property string $parentId
+ * @property int|null $position The line index of the item in its bulk operation file (since 7.3.1)
  * @property string $dateCreated
  * @property string $dateUpdated
  * @property string $uid

src/services/Api.php

@@ -536,7 +536,7 @@ public function getShopifyDataByType(string $type, array|string|null|false $pare
 
         $data = ShopifyData::find()
             ->where($criteria)
-            ->orderBy(['id' => SORT_ASC])
+            ->orderBy(['position' => SORT_ASC, 'id' => SORT_ASC])
             ->collect();
 
         // The caller can request the raw database rows, instead of just the `data` JSON column:

tests/unit/jobs/ProcessBulkOperationDataTest.php

@@ -292,6 +292,30 @@ public function testExecuteProcessesEveryLineOnceAcrossBatches(): void
         self::assertEquals(58, ShopifyData::find()->where(['parentId' => $productGid])->count());
     }
 
+    public function testExecuteStoresChildrenInTheOrderTheyAppearInTheFile(): void
+    {
+        $productGid = 'gid://shopify/Product/order-test-001';
+        $imageGids = [];
+        $lines = [json_encode(['id' => $productGid])];
+        foreach (range(1, 5) as $i) {
+            $imageGids[] = "gid://shopify/MediaImage/order-test-$i";
+            $lines[] = json_encode(['id' => end($imageGids), '__parentId' => $productGid]);
+        }
+
+        $filePath = Assets::tempFilePath('jsonl');
+        file_put_contents($filePath, implode("\n", $lines) . "\n");
+
+        Plugin::getInstance()->set('products', $this->makeEmpty(Products::class, [
+            'createOrUpdateProduct' => true,
+        ]));
+
+        $this->_runJob($this->_makeExecutableJob($filePath, count($lines), 'all', batchSize: 2));
+
+        $images = Plugin::getInstance()->getApi()->getShopifyDataByType('MediaImage', $productGid);
+
+        self::assertSame($imageGids, $images->pluck('id')->all());
+    }
+
     /**
      * A TTR of zero makes every batch stop after its first item, leaving the rest of its slice unprocessed.
      */