Repository navigation
fix: read the trust key table's sources and report dates from a committed capture of the public records - #78
Merged
Conversation
…tted capture of the public records trustgen reads each row's source and reported from pkg/patterns/testdata/trust-captured/source-records.txt: one line per public record, with the UTC time it states for itself, its role and the keys it lists. A row's source is the sorted URLs of the records that list it, and its reported is the UTC date of the earliest of those that reports its status. The generator refuses a record that lists no row, a row that no status record lists, a row with a record dated before its earliest status record, and a time that is not UTC. The table test derives each row's source and reported from the committed capture, and refuses a table with a row reported a day before its earliest record or citing a record that does not list it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lands 1 commit in pkg/patterns.
Included
Verified on this exact tree
go build ./...: exit 0go vet ./...: exit 0golangci-lint run --concurrency 4 --max-same-issues 0 --max-issues-per-linter 0 ./...: exit 1, 91 issues (errcheck 50, staticcheck 41); the same command on origin/main at 3cf00b2: exit 1, 90 issues (errcheck 50, staticcheck 40); the one issue not in the origin/main list:pkg/patterns/internal/trustgen/main.go:331:14: ST1005: error strings should not end with punctuation or newlines (staticcheck)go test -race -count=1 -p 4 -v ./...: exit 0; 8 packages ok, 2 packages with no test files; 438 top-level tests passed (1362 including subtests), 0 failed, 0 skippedNot included
None
Closes
None
How to merge
Rebase and merge, so that each change stays its own commit on
main.