[choppedpork]

One more small fix 🙂

--log-format json currently has no effect: every format goes through zerolog's ConsoleWriter, which converts log events into human-readable text, so json produces plain text lines rather than one JSON object per line. This PR makes json write zerolog's native JSON with a timestamp, in both normal and --debug mode. human
output is unchanged.

When the flag was added in d925b0a it worked, because the ConsoleWriter was only set up for human and json kept zerolog's default JSON logger. caf6a05 then moved the debug and human settings onto a shared consoleWriter and assigned log.Logger = log.Output(consoleWriter) unconditionally, so json has gone through the
console writer ever since.

That's why the diff is bigger than the bug: json needs its own logger rather than a differently configured ConsoleWriter. Logger construction now lives in newLogger, which takes an io.Writer so both formats can be tested against a buffer.

[dag-andersen]

Wow, that bug has been around for a long time! clearly no one is using that feature haha - Great work!