[guarnz]

Summary

• When the Redis container is stuck in ImagePullBackOff or ErrImagePull, the crash watcher now logs a hint right after the existing error: the registry may be rate limiting anonymous pulls, and the Redis image repository (redis.image.repository) can be overridden in the Argo CD Helm chart values, with a link to the custom Argo CD installation docs.
• The hint is only for Redis, the image the chart pulls from ECR Public. Pull failures in other containers keep just the existing error, since there they are more likely a wrong tag or a private registry.
• As suggested in Fix | Pull Redis from mirror.gcr.io to avoid ECR Public rate limits #502. Refs Bug | Redis pulls from ECR Public hit rate limits on GitHub-hosted runners #507

Testing

• go test ./cmd/... ./pkg/...
• New tests: TestImagePullHint_Redis and TestImagePullHint_OtherContainers

[dag-andersen]

Sorry, I almost forgot about this PR 🚀

However, it seems like your issue is getting a lot of upvotes, so maybe this is a bigger problem than i thought 👀

[guarnz]

No worries, thanks for merging!

Yeah, my only worry is that if most people end up adding their own override, things can break in ways your CI won't catch, since it tests the default setup and not each override. But let's see if #507 keeps growing. #502 is still open, so if it comes to that I can update it to make the mirror the default and adjust the hint from this PR.

If you'd rather keep exactly the same image as ECR, another option would be copying it to a public registry of your own (like GHCR, with something like crane copy), so the digest stays the same but it's pulled from a registry that belongs to argocd-diff-preview. But I think that adds complexity that probably isn't needed 😅