Repository navigation
fix: sync default welcome text with display language - #1425
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
修复切换语言后助手、页面嵌入及登录页的默认欢迎语仍保持中文,以及“恢复默认”保存后再次固化语言的问题。
统一基础/高级助手浮窗与全屏、普通问数首页、页面嵌入、登录页及外观预览。助手显示设置、外观设置的登录区域和平台区域分别恢复各自默认文案,保留登录欢迎语显示开关。同步修正繁中版本名称与韩语默认密码提示的 3 处键名。
Evidence
8885a81a上,高级助手及页面嵌入切换泰语后的欢迎语断言失败,实际仍为中文;登录区域恢复默认提交了中文字符串,切换语言断言同样失败。After:
npm --prefix tests/browser test -- --config=welcome-language.config.mjs:10 passed。覆盖五种语言、缺失/空值/历史默认值、自定义文案、恢复默认、保存、重新打开、再次编辑及显示开关。cd backend && .venv/bin/python -m pytest -q tests/test_assistant_welcome_defaults.py tests/test_embedded_datasource_navigation.py tests/test_embedded_auth_bypass_fix.py:47 passed,复用已准备环境,未同步依赖。保存用例提取实际 Schema/handler 并隔离数据库与鉴权。cd frontend && npm run build通过;改动前端文件 ESLint、新增 Python 测试 Ruff 通过。五种语言 JSON 键结构一致,修正的翻译键及参数替换验证通过。Merge Danger
Door: two-way
无数据库迁移、接口或依赖变更。若回滚旧前端,已经保存为空字符串的默认配置需要配套处理,否则旧显示逻辑可能显示空白欢迎语。
Blast Radius: i18n
影响助手、问数与登录欢迎语及其设置预览。旧配置没有来源标记,因此手工输入且恰好等于五种语言系统默认文案的内容,也会按默认模式处理;其余自定义内容不裁剪、不翻译。