Repository navigation
Conversation
WofWca
force-pushed
the
wofwca/webxdc-permissions-2
branch
from
October 10, 2026 19:48
f12eba6 to
9113912
Compare
WofWca
force-pushed
the
wofwca/webxdc-permissions-2
branch
from
October 15, 2026 15:50
9113912 to
09d96a8
Compare
WofWca
force-pushed
the
wofwca/webxdc-permissions-2
branch
from
October 15, 2026 16:01
09d96a8 to
2f7c7ab
Compare
WofWca
added this pull request to stack #6864
October 16, 2026 20:07
https://www.electronjs.org/docs/latest/api/menu#menugetapplicationmenu : > Note: The returned Menu instance doesn't support dynamic addition > or removal of menu items. Instance properties > can still be dynamically modified. Also https://stackoverflow.com/questions/47756822/change-electrons-menu-items-status-dynamically/47761652#47761652 I checked and it works
WofWca
force-pushed
the
wofwca/webxdc-permissions-2
branch
from
October 16, 2026 20:08
2f7c7ab to
b9b1364
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6813.
Closes https://support.delta.chat/t/allow-access-to-camera-geolocation-other-web-apis/2446?u=wofwca
Supersedes #4008.
webxdc-permissions.webm
TODO:
Clean up the code, squash some commits.
But overall this is already close to how I want the code to be.
(maybe for a follow-up) notify the user when a permission is requested.
But be careful with dialogs to avoid spam.
If think a menu will be needed anyway, so as to allow revoking permissions.