Repository navigation
Make building the app and use of toml-f optional - #252
Open
jamesagreen wants to merge 2 commits into
Open
jamesagreen wants to merge 2 commits into
jamesagreen wants to merge 2 commits into
Conversation
- Introduce a CMake variable SDFTD3_WITH_APP which is default true, but can be set to false to disable the building of the app - This means that the inclusion of toml-f as a dependency can be made optional. - This is done due to some compiler bugs (particularly older versions of NVHPC and intel classic compilers) in building the toml-f library
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 63.35% 63.45% +0.09%
==========================================
Files 47 47
Lines 6852 6832 -20
Branches 2435 2425 -10
==========================================
- Hits 4341 4335 -6
+ Misses 1197 1184 -13
+ Partials 1314 1313 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- It isn't strictly true that simply disabling the app build in meson makes toml-f optional, because the meson build uses the json=auto option with mctc-lib, which pulls in toml-f via the jonquil for reading JSON - Tightened up the wording in the documentation for meson regarding this.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDFTD3_WITH_APPand meson optionappwhich are default true, but can be set to false to disable the building of the app.