Repository navigation
ansi-c library: model strtoll, strtoul and strtoull - #9439
Open
tautschnig wants to merge 1 commit into
Open
tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
C23 7.24.1.7: same conversion rules as strtol, which CBMC already models; the three sibling spellings had NO model, so calls returned nondeterministic values -- std::stoll (via libstdc++'s __stoa) and CBMC's own unsafe_string2int/string2optional silently produced garbage, discovered by a unit proof over src/util/string2int.cpp. The models mirror the existing strtol model with the result type adjusted; the unsigned variants negate the converted value for a leading '-' (C23 7.24.1.7/5). Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
requested review from
kroening,
peterschrammel and
remi-delmas-3000
as code owners
November 10, 2026 20:35
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Nov 10, 2026
POSIX.1-2024 (and glibc, macOS) have the conversions of strtol and its siblings with an explicit locale; the conversion of integers does not depend on it beyond the white-space and digit characters, which the existing models take from the "C" locale. The models call those of strtol, strtoul, strtoll and strtoull. glibc names them __isoc23_*_l in C23 mode, which get the same models. libc++'s num_get converts every integer it reads with strtoll_l or strtoull_l, which had no model. New tests strtol_l, strtoul_l, strtoll_l and strtoull_l. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com> Depends-on: diffblue#9439
4 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9439 +/- ##
========================================
Coverage 81.02% 81.03%
========================================
Files 1723 1723
Lines 191314 191314
Branches 73 73
========================================
+ Hits 155020 155023 +3
+ Misses 36294 36291 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kroening
approved these changes
Nov 10, 2026
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C23 7.24.1.7: same conversion rules as strtol, which CBMC already models; the three sibling spellings had NO model, so calls returned nondeterministic values -- std::stoll (via libstdc++'s __stoa) and CBMC's own unsafe_string2int/string2optional silently produced garbage, discovered by a unit proof over src/util/string2int.cpp. The models mirror the existing strtol model with the result type adjusted; the unsigned variants negate the converted value for a leading '-' (C23 7.24.1.7/5).