Repository navigation
library_check: exclude tests.log from regression/cbmc-library scan - #9443
Open
tautschnig wants to merge 1 commit into
Open
tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
library_check.sh enumerates regression/cbmc-library/ to build the list of expected test directories and cross-checks it against the library function table. The test runner (regression/test.pl) leaves a tests.log behind in that directory after a run, and on a subsequent cmake build the entry appears in __tests without a matching __functions line, aborting the build: --- __tests +++ __functions -tests.log Tests and library functions don't match. This reliably breaks out-of-tree Docker builds after the host has run the regression suite once. Extend the egrep exclusion to skip tests.log alongside Makefile and CMakeLists.txt. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
requested review from
kroening,
peterschrammel and
remi-delmas-3000
as code owners
November 10, 2026 20:40
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
kroening
approved these changes
Nov 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9443 +/- ##
========================================
Coverage 81.02% 81.02%
========================================
Files 1723 1723
Lines 191314 191314
Branches 73 73
========================================
Hits 155020 155020
Misses 36294 36294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
library_check.sh enumerates regression/cbmc-library/ to build the list of expected test directories and cross-checks it against the library function table. The test runner (regression/test.pl) leaves a tests.log behind in that directory after a run, and on a subsequent cmake build the entry appears in __tests without a matching __functions line, aborting the build:
--- __tests
+++ __functions
-tests.log
Tests and library functions don't match.
This reliably breaks out-of-tree Docker builds after the host has run the regression suite once. Extend the egrep exclusion to skip tests.log alongside Makefile and CMakeLists.txt.