Repository navigation
fix(wrap): explicitly fail if the declared cgroup cannot be joined - #196
Merged
bleggett merged 1 commit intoOct 26, 2026
Merged
Conversation
azenla
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, if a cgroup could not be joined, the
execwould continue, in the wrong cgroup, without the caller realizing it.This changes the code such that if the attach fails,
attachfalls back to the target process's cgroup, as runc's exec does, and fails only if that also fails.This is technically a breaking change, but it is a better security posture: a create or attach whose named cgroup cannot be joined used to warn and silently run the process outside that cgroup - now, it fails explicitly.