Skip to content

Fix erroneous PR links and formatting in ChangeLog - #28025

Merged
sbc100 merged 2 commits into
emscripten-core:mainfrom
aheejin:changelog_fix
Oct 20, 2026
Merged

sbc100 merged 2 commits into
emscripten-core:mainfrom
aheejin:changelog_fix

Conversation

@aheejin

@aheejin aheejin commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

These include

  • Typos in PR numbers
  • Missing PR numbers (like (#) or ())
  • Missing # or closing ) in PR/issue references
  • Missing a follow-up PR when two PRs comprise a single ChangeLog entry
  • Copy-paste mistakes (mistakenly copying a number from the line above)
  • Closed/unmerged PRs superseded by another PR, or split-out PRs. e.g., you start a PR and close it and reimplemented it in another PR, but the ChangeLog points to the old PR. Also you start a PR and split-out the change that's in ChangeLog into another smaller PR but the ChangeLog stil points to the old PR.

Gemini-generated and human-verified.

These include
- Typos in PR numbers
- Missing PR numbers (like `(#)` or `()`)
- Missing `#` or closing `)` in PR/issue references
- Missing a follow-up PR when two PRs comprise a single ChangeLog entry
- Copy-paste mistakes (mistakenly copying a number from the line above)
- Closed/unmerged PRs superseded by another PR, or split-out PRs. e.g.,
  you start a PR and close it and reimplemented it in another PR, but
  the ChangeLog points to the old PR. Also you start a PR and split-out
  the change that's in ChangeLog into another smaller PR but the
  ChangeLog stil points to the old PR.

Gemini-generated and manually verified.
@aheejin
aheejin requested a review from sbc100 October 20, 2026 07:00

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates ChangeLog.md to correct several issue numbers, add missing '#' prefixes, and fix formatting issues such as a missing closing parenthesis. The review feedback suggests a grammatical improvement on one of the modified lines, recommending changing 'defaults for' to 'defaults to'.

Comment thread ChangeLog.md Outdated
@sbc100
sbc100 merged commit 7679106 into emscripten-core:main Oct 20, 2026
40 of 42 checks passed
@aheejin
aheejin deleted the changelog_fix branch October 20, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants