Repository navigation
Handle DEPS.tagged-release in sync_deps.py - #28031
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to detect and handle tagged releases of the Emscripten SDK by checking for the presence of a 'DEPS.tagged-release' file in the commit. This check is implemented in both 'rebaseline_tests.py' and 'sync_deps.py'. The feedback suggests improving the robustness of the network requests by using a 'with' statement in 'rebaseline_tests.py' to prevent resource leaks, and adding a timeout to the request in 'sync_deps.py' to prevent it from hanging indefinitely.
sbc100
force-pushed
the
tagged_release_deps
branch
from
October 20, 2026 17:32
79c48dd to
f5e2512
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 20, 2026
When a release candidate commit in `emscripten-releases` modifies `DEPS.tagged-release`, the waterfall builds that revision using `DEPS.tagged-release` (which may be branched from an older revision) rather than `DEPS`. Teach `tools/maint/sync_deps.py` to fetch `DEPS.tagged-release` when the target `emscripten-releases` revision modifies that file, matching what the corresponding prebuilt `emsdk` archive was built from. This is needed because we actually did sync to tagged release in emscripten-core#28031.
sbc100
force-pushed
the
tagged_release_deps
branch
from
October 20, 2026 17:51
f5e2512 to
807c865
Compare
sbc100
changed the title
DEPS.tagged-release in sync_deps.py and rebaseline_tests.pyDEPS.tagged-release in sync_deps.py
Collaborator
Author
|
Simplified to only change sync_deps.py |
When a release candidate commit in `emscripten-releases` modifies `DEPS.tagged-release`, the waterfall builds that revision using `DEPS.tagged-release` (which may be branched from an older revision) rather than `DEPS`. Teach `tools/maint/sync_deps.py` to fetch `DEPS.tagged-release` when the target `emscripten-releases` revision modifies that file, matching what the corresponding prebuilt `emsdk` archive was built from. This is needed because we actually did sync to tagged release in emscripten-core#28031.
sbc100
force-pushed
the
tagged_release_deps
branch
from
October 20, 2026 18:51
807c865 to
72725ae
Compare
sbc100
enabled auto-merge (squash)
October 20, 2026 19:25
dschuff
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a release candidate commit in
emscripten-releasesmodifiesDEPS.tagged-release, the waterfall builds that revision usingDEPS.tagged-release(which may be branched from an older revision)rather than
DEPS.Teach
tools/maint/sync_deps.pyto fetchDEPS.tagged-releasewhenthe target
emscripten-releasesrevision modifies that file, matchingwhat the corresponding prebuilt
emsdkarchive was built from.This is needed because we actually did sync to tagged release in #28031.