Repository navigation
Match type case to the parser in the purl generator - #167
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzzer intermittently failed because the generator resolved a type's spec with an exact registry lookup, while the parser downcases the type first. A random "unknown" type that spells a registered one, such as
pUB, therefore got the permissive default spec when generated andpub's strict spec when reparsed, so the generated purl was rejected.Both lookups now downcase first, and the unknown-types branch reuses
type_has_permitted_characters?/1as a filter so it cannot emit a case variant of a strict type. The known-types branch already excluded those.