Repository navigation
Conversation
kratz00
requested a deployment
to
v2-fuzzing-pr-approval
October 28, 2026 12:17 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
kratz00
force-pushed
the
feature/stream_management_specification
branch
from
October 28, 2026 12:21
f794845 to
9b743c1
Compare
kratz00
requested a deployment
to
v2-fuzzing-pr-approval
October 28, 2026 12:21 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>
kratz00
force-pushed
the
feature/stream_management_specification
branch
from
October 28, 2026 12:25
9b743c1 to
161cf56
Compare
kratz00
requested a deployment
to
v2-fuzzing-pr-approval
October 28, 2026 12:25 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
tkilias
reviewed
Oct 28, 2026
Comment on lines
+54
to
+62
| OutboundEnvelope { | ||
| StreamId stream_id // 0 for ControlMessageBuilder | ||
| CallMessageBuilder | ControlMessageBuilder builder | ||
| } | ||
|
|
||
| InboundEnvelope { | ||
| StreamId stream_id // 0 for ControlMessageView | ||
| CallMessageView | ControlMessageView view | ||
| } |
Contributor
There was a problem hiding this comment.
in theory the flatbuffer objects contain the stream id, so do we need this actually
tkilias
reviewed
Oct 28, 2026
| - stream `0` goes to the control-stream pending list; | ||
| - an envelope for a known nonzero `stream_id` goes to that stream's pending | ||
| list; | ||
| - an opening message for a never-created odd stream creates an inbound-call |
Contributor
There was a problem hiding this comment.
we cant simply say odd, it depends on what kind of context we have
tkilias
reviewed
Oct 28, 2026
|
|
||
| ## Close and ID lifetime | ||
|
|
||
| The worker-owned call registry keeps a closed-stream set keyed by `stream_id`. |
Contributor
There was a problem hiding this comment.
I would like to avoid storing all closed stream id. We already remember stream ids for open calls and we could remember the highest used stream id for each side and reject any messages for stream ids that are smaller and not open
# Conflicts: # doc/design/v2/runner/README.md
kratz00
requested a deployment
to
v2-fuzzing-pr-approval
November 4, 2026 13:40 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>
kratz00
requested a deployment
to
v2-fuzzing-pr-approval
November 5, 2026 09:12 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>
Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>
kratz00
requested a deployment
to
v2-fuzzing-pr-approval
November 5, 2026 09:28 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>
kratz00
requested a deployment
to
v2-fuzzing-pr-approval
November 5, 2026 15:34 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>
kratz00
requested a deployment
to
v2-fuzzing-pr-approval
November 5, 2026 15:44 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>
kratz00
requested a deployment
to
v2-fuzzing-pr-approval
November 5, 2026 17:34 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>
kratz00
requested a deployment
to
v2-fuzzing-pr-approval
November 5, 2026 19:18 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
|
tkilias
reviewed
Nov 5, 2026
| an abnormal call termination. Without `Error`, it is normal termination. After sending or receiving `CloseCall`, the | ||
| local endpoint sends no further call-scoped traffic on that stream. Messages already in transit may still arrive after | ||
| either event; the endpoint ignores those late stream messages while still processing a received `CloseCall`. | ||
| either event. The low-level context discards delayed messages for inactive peer-owned stream IDs as described in the |
Contributor
There was a problem hiding this comment.
protocol does not know about the context
tkilias
reviewed
Nov 5, 2026
| Sending or receiving `CloseCall` makes the local endpoint's outbound direction terminal: it sends no further schema, | ||
| batch, send budget, `Reset(...)`, or other call-scoped message. A `CloseCall` is not acknowledged. Messages already in flight may | ||
| still arrive after either endpoint sends or receives `CloseCall`; late messages for the closed stream are ignored. | ||
| still arrive after either endpoint sends or receives `CloseCall`. Delayed messages for inactive peer-owned stream IDs |
Contributor
There was a problem hiding this comment.
protocol doesnt know about runner
tkilias
reviewed
Nov 5, 2026
| The worker-owned call registry keeps a closed-stream set keyed by `stream_id`. Closing a call records its stream ID | ||
| before releasing its pending sequence, so delayed messages can be discarded without confusing them with a new call; | ||
| stream IDs are never reused on a connection. | ||
| The worker-owned call registry tracks active streams and the high-water state described in |
tkilias
reviewed
Nov 5, 2026
| does not own `Call` or `ControlStream` instances and does not dispatch to | ||
| worker-facing objects. | ||
|
|
||
| ## Stream-ID ownership and allocation |
Contributor
There was a problem hiding this comment.
this basically a copy from the protocol
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109