You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
this doesnt work properly, also if you prevent a race with a mutex, the get_next_connection might wait without timeout and the a potential parallel shutdown signal can't simply close the socket, because under linux this doesnt wake the thread that currently blocks in accept. You need to use epoll and a eventfd. you register the listener socket and the eventfd at the epoll and wait on the epoll. shutdown then sends a message to the eventfd and wakes up the thread waiting for a connection. futhermore shutdown should marke the connectionacceptor as shutdown and prevent further waits. the socketlistener is then in the destructor destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #119